Worth noting that this is not the only place AT.FDCWD can cause problems (e.g. I know os.fstat has the same issue but the fix there is much less clear), and I'm unsure about exactly where this type of thing should be accounted for. For example, this same issue could be fixed by doing

if (dirfd == AT.FDCWD) return;

in std.os.fchdir instead. Note that this alternate fix would also avoid EBADF when doing something like:

test {
    const cwd = fs.cwd();
    try cwd.setAsCwd();
}

whereas the implementation in this PR would still hit EBADF in that case.

Right. Let's see if the maintainers would prefer this fix.

Got it, I'll open this as a new PR as this one is getting pretty outdated and contains a redundant commit.